Skip to content

Make GitLab pages support access control

Tuomo Ala-Vannesluoma requested to merge tuomoa/gitlab-foss:auth into master

What does this MR do?

Adds option to use GitLab access control in project pages #33422 (closed) and implement the necessary changes for pages config file generation.

This depends on the pages MR gitlab-pages!94 (merged).

The changes required for GitLab to automatically configure necessary pages client id, secret etc. are implemented in omnibus-gitlab!2583 (merged).

All feedback is appreciated!

Testing

At the moment this can be tested by creating the authentication id and secret manually and compiling GitLab pages from gitlab-pages branch.

CI

I haven't done any changes to gitlab-ee so the ee_compat_check job is failing at the moment.

Are there points in the code the reviewer needs to double check?

Not that I know of.

Why was this MR needed?

Closes #33422 (closed).

Screenshots (if relevant)

Screenshot_from_2018-09-11_14-57-02

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#33422 (closed)

Edited by Nick Thomas

Merge request reports

Loading