Pages in project's permissions settings should be named Pages access control

Problem to solve

Make it clear what the Pages permission toggle does.

Further details

In https://gitlab.com/gitlab-org/gitlab-ce/issues/33422, we added Pages access control and that introduced a change in the project's permissions

Pages access control

Like it's written now, I'd expect the toggle to completely disable Pages, whereas this only toggles the access control status.

If you disable the rest of the other features, they disappear from the menu, which is not the case with Pages.

Proposal

I see two options here:

  1. Change the permissions name from "Pages" to "Pages access control".
  2. Make it so the toggle also disables Pages.

Links / references

Edited by Achilleas Pipinellis