QA: Remove flaky and redundant expectations
What does this MR do?
Remove flaky and redundant expectations.
- Resolves https://gitlab.com/gitlab-org/gitlab-ce/issues/49164
- This was first brought up in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18696#note_71707086 but we decided the expectations should be removed in a separate MR
- These expectations are redundant with the main expectations in these tests
- These expectations should be tested in non-QA feature specs. As it turns out, this is already the case: https://gitlab.com/gitlab-org/gitlab-ee/blob/9510f8bf36a937f87d5af804812e1c2b423d5259/spec/features/protected_branches_spec.rb
- Improves QA spec performance
Are there points in the code the reviewer needs to double check?
EE Port: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6505
Why was this MR needed?
False positives during staging failover rehearsal QA.
Does this MR meet the acceptance criteria?
- Conform by the code review guidelines
-
Has been reviewed by a Backend maintainer
-
-
Conform by the merge request performance guides -
Conform by the style guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Resolves https://gitlab.com/gitlab-org/gitlab-ce/issues/49164
Edited by Rémy Coutable