Resolve "[Rails5] `StorageHelper#storage_counter uses commas as thousands separator` fails"
What does this MR do?
Since rails 5 beta 2 support of petabytes and exabytes were added to the number_to_human*
methods.
See https://github.com/rails/rails/pull/22759
So for rails5 the comma separator gets shown for big numbers (EBs).
Are there points in the code the reviewer needs to double check?
No.
Why was this MR needed?
Screenshots (if relevant)
No.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Conform by the code review guidelines
-
Has been reviewed by a UX Designer -
Has been reviewed by a Frontend maintainer -
Has been reviewed by a Backend maintainer -
Has been reviewed by a Database specialist
-
-
Conform by the merge request performance guides -
Conform by the style guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
Internationalization required/considered -
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Closes #47375 (closed)
Edited by Rémy Coutable