Skip to content

Resolve "[Rails5] `StorageHelper#storage_counter uses commas as thousands separator` fails"

blackst0ne requested to merge blackst0ne-rails5-fix-storage-counter-helper into master

What does this MR do?

Since rails 5 beta 2 support of petabytes and exabytes were added to the number_to_human* methods.
See https://github.com/rails/rails/pull/22759

So for rails5 the comma separator gets shown for big numbers (EBs).

Are there points in the code the reviewer needs to double check?

No.

Why was this MR needed?

Migration to Rails 5.0.

Screenshots (if relevant)

No.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #47375 (closed)

Edited by Rémy Coutable

Merge request reports

Loading