Add feature flag to disable LFS check
What does this MR do?
Adds feature flag to disable LFS pointer check instance wide
Related issue
Merge request reports
Activity
changed milestone to %11.11
added Create [DEPRECATED] devopscreate feature flag labels
1 Warning a26c5efe: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Mark Fletcher ( @markglenfletcher
)Michael Kozono ( @mkozono
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖@markglenfletcher could you please review this MR?
assigned to @markglenfletcher
@igor.drozdov The changes looks good.
Do you think that this should be documented so that instance admins can find information about it in the docs? And also a changelog item to advertise the introduction of the flag?
It seems that based on the feature flag docs this flag will default to being enabled. So instance admins will not have to make changes to keep lfs checks running on their own instances where they are noticing no impact.
assigned to @igor.drozdov
Do you think that this should be documented so that instance admins can find information about it in the docs? And also a changelog item to advertise the introduction of the flag?
@markglenfletcher It's only intended to be a temporary escape hatch we can tell the affected customers to use while we make time to work on the other improvements in https://gitlab.com/gitlab-org/gitlab-ce/issues/60591 in future releases, so I'd prefer not to document it.
It seems that based on the feature flag docs this flag will default to being enabled.
That's not quite right; it's only implicit feature flags, aka feature flags for licensed features, that are on by default. In this case, we'd want to add
default_enabled: true
.Edited by Douwe Maanadded backstage [DEPRECATED] label
assigned to @DouweM
- Resolved by Douwe Maan
assigned to @igor.drozdov
added 250 commits
-
197c0c10...9ec37d3d - 249 commits from branch
master
- 681db75b - Add feature flag to disable LFS check
-
197c0c10...9ec37d3d - 249 commits from branch
assigned to @DouweM
- Resolved by Douwe Maan
added 1 commit
- a26c5efe - Apply suggestion to spec/lib/gitlab/checks/lfs_check_spec.rb