Skip to content

(Part 1) FE multiple approval rules - settings empty state

(CE Port https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24087)

What does this MR do?

This MR sets up the structure for the multiple approval rules settings. To keep this MR focused, it only shows the empty state. The full functionality will be implemented by upcoming MRs.

Please Note!

  • This does not point to master. We will merge the FE branch once the BE is merged. We'll go ahead and merge the backstage CE port to master.
  • This is behind the feature flag approval_rule. You will need to enable this feature locally to test.
  • There is no integration with the BE. This integration will be merged in a separate MR. See branch 1979-fe-settings-integrated.

Screenshots

Feature.enable(:approval_rule) Feature.disable(:approval_rule) (default)
Screen_Shot_2018-12-31_at_5.00.30_PM Screen_Shot_2018-12-31_at_5.02.37_PM

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Edited by Paul Slaughter

Merge request reports