Skip to content

(Part 2) FE multiple approval rules - settings full

Paul Slaughter requested to merge 1979-fe-settings into 1979-fe-multiple-approval-rules

What does this MR do?

This MR implements the FE components for multiple approval rule settings.

Please note! To make this MR smaller, the Vuex part has been split into a separate MR https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9043, but this MR still contains the functionality in a merge commit.

What will be handled in a separate MR?

  • Spec for approvers_select.
  • License feature with only a single approval rule.

Instructions

  • This does not point to master. We will merge the FE branch once the BE is merged.
  • This is behind the feature flag approval_rule. You will need to enable this feature locally to test.
  • Do not merge until Part 3 !9043 (merged) has been merged and the related merge commit has been rebased out.
  • Please merge the CE MRs to CE master first.

CE MR's

Screenshots

Demo Mobile View List Mobile View Form
20190103_1979_settings Screen_Shot_2019-01-04_at_12.08.55_AM Screen_Shot_2019-01-04_at_12.09.13_AM

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Edited by Paul Slaughter

Merge request reports