Skip to content

[CI Review Apps] Change `pullPolicy` to `Always` for `gitlab.sidekiq.image` and `gitlab.unicorn.image` and pass `FORCE_RAILS_IMAGE_BUILDS=true` to the `CNG-mirror` triggered pipeline to always rebuild the Rails image

Rémy Coutable requested to merge 62149-ci-review-apps-change-pullpolicy-sidekiq-and-unicorn into master

What does this MR do?

This fixes a problem when a subsequent push to a branch wouldn't be reflected in the Review Apps after the first deployment since the CNG-mirror uses the branch name to check if the image needs to be built.

  1. This sets the pullPolicy to Always for the gitlab.sidekiq.image and gitlab.unicorn.image components.
  2. This also passes FORCE_RAILS_IMAGE_BUILDS=true to the CNG-mirror triggered pipeline to always rebuild the Rails image. This requires gitlab-org/build/CNG!231 (merged).

One obvious caveat is that this could make the pipeline slower since review-build-cng will take longer. A few example from this MR:

That means gitlab:assets:compile + review-build-cng would probably take 40 minutes (meaning that the test stage would take 40 minutes).

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #62149 (closed).

Edited by Rémy Coutable

Merge request reports