Skip to content

[CI Review Apps] Change `pullPolicy` to `Always` for `gitlab.sidekiq.image` and `gitlab.unicorn.image`

I discovered in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/13111#note_173211230 that we're using the imagePullPolicy: IfNotPresent Docker pull policy for the gitlab.sidekiq.image and gitlab.unicorn.image images even though https://gitlab.com/charts/gitlab/blob/master/doc/installation/command-line-options.md#advanced-gitlab-configuration states that the default policy is Always, that's not the case when looking at the YAML config in Kubenertes, e.g.:

        image: registry.gitlab.com/gitlab-org/build/cng-mirror/gitlab-sidekiq-ce:sh-bump-shoulda-matcher
        imagePullPolicy: IfNotPresent

This is for the following merge request: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28443.

We should overwrite the policy by passing --set gitlab.sidekiq.image.pullPolicy=Always and --set gitlab.unicorn.image.pullPolicy=Always in https://gitlab.com/gitlab-org/gitlab-ce/blob/3846f89d4f9164e16313c11a78bdf9fa3ee2294e/scripts/review_apps/review-apps.sh#L225.