Skip to content

perf(redis): clean up redis cache use across codebase

Pawel Rozlach requested to merge prozlach/make_redis_cache_global into prozlach/tmp

What does this MR do?

Resolves #1056 (closed) Resolves #1305 (closed)

This MR unifies the way we handle Redis-based repository cache as per #1056 (closed).

As agreed in !1679 (comment 1997284351) we now use MockRepositoryCache to make tests independent of underlying cache implementation. I have unified the way we pass the cache across functions and refactored/DRYied unittests in few places to accommodate the changes.

Due to the fact that some code paths do not use cache, I did not use a wrapper function exactly as discussed in !1679 (comment 1996889183) and instead opted for checks if cache is enabled before call to datastore.WithRepositoryCache(...) in datastore.Maybe() function.

In theory we could try to minimize/simplify the code further, but in practice I would like to keep the complexity/size of this MR at bay and minimize the risks that it brings. We can always iterate on it later if the need arises. I believe that the main goal of this refactoring - centralisation of Redis-based cache setup - has been achieved.

Author checklist

  • Feature flags
    • Added feature flag:
    • This feature does not require a feature flag
  • I added unit tests or they are not required
  • I added documentation (or it's not required)
  • I followed code review guidelines
  • I followed Go Style guidelines
  • For database changes including schema migrations:
    • Manually run up and down migrations in a postgres.ai production database clone and post a screenshot of the result here.
    • If adding new queries, extract a query plan from postgres.ai and post the link here. If changing existing queries, also extract a query plan for the current version for comparison.
      • I do not have access to postgres.ai and have made a comment on this MR asking for these to be run on my behalf.
    • Do not include code that depends on the schema migrations in the same commit. Split the MR into two or more.
  • Ensured this change is safe to deploy to individual stages in the same environment (cny -> prod). State-related changes can be troublesome due to having parts of the fleet processing (possibly related) requests in different ways.

Reviewer checklist

  • Ensure the commit and MR tittle are still accurate.
  • If the change contains a breaking change, apply the breaking change label.
  • If the change is considered high risk, apply the label high-risk-change
  • Identify if the change can be rolled back safely. (note: all other reasons for not being able to rollback will be sufficiently captured by major version changes).

If the MR introduces database schema migrations:

  • Ensure the commit and MR tittle start with fix:, feat:, or perf: so that the change appears on the Changelog
If the changes cannot be rolled back follow these steps:
  • If not, apply the label cannot-rollback.
  • Add a section to the MR description that includes the following details:
    • The reasoning behind why a release containing the presented MR can not be rolled back (e.g. schema migrations or changes to the FS structure)
    • Detailed steps to revert/disable a feature introduced by the same change where a migration cannot be rolled back. (note: ideally MRs containing schema migrations should not contain feature changes.)
    • Ensure this MR does not add code that depends on these changes that cannot be rolled back.
Edited by João Pereira

Merge request reports

Loading