fix(datastore): do not panic if database credentials are wrong
Problem
Currently, the registry panic
s when starting if the PostgreSQL credentials are wrong. Credentials are configured in the database
section of the configuration file.
Solution
Investigate why this causes a panic
and why the error is not being handled gracefully. Fix it.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- 🤖 GitLab Bot 🤖 added sectionops label
added sectionops label
- João Pereira set weight to 1
set weight to 1
- João Pereira added workflowready for development label and removed workflowscheduling label
added workflowready for development label and removed workflowscheduling label
- João Pereira added [deprecated] good for new contributors label
added [deprecated] good for new contributors label
- João Pereira changed title from Fix panic when database credentials are wrong to fix(datastore): do not panic if database credentials are wrong
changed title from Fix panic when database credentials are wrong to fix(datastore): do not panic if database credentials are wrong
- João Pereira added priority2 label
added priority2 label
- João Pereira changed the description
Compare with previous version changed the description
- Tim Rizzi added Package:P2 Stretch labels
added Package:P2 Stretch labels
- Tim Rizzi mentioned in issue gitlab#341294 (closed)
mentioned in issue gitlab#341294 (closed)
- João Pereira mentioned in issue gitlab-org/ci-cd/package-stage/onboarding#11 (closed)
mentioned in issue gitlab-org/ci-cd/package-stage/onboarding#11 (closed)
- Jaime Martinez assigned to @jaime
assigned to @jaime
- Jaime Martinez changed milestone to %14.6
changed milestone to %14.6
- Maintainer
Starting on this issue this week
😄 - Jaime Martinez added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Maintainer
@jdrpereira do we still want to fail to start or should we keep running but disable the datastore (and print a warning)?
Collapse replies - Author Maintainer
@jaime, as a general rule of thumb, if a user/admin requested a feature to be enabled, then we should fail to start if we can't setup/verify the pre-requisites for that feature.
In this specific case, we should definitely fail as soon as possible, otherwise, this could lead to data inconsistencies or at least unavailability for repositories stored in the database.
1
- Jaime Martinez mentioned in merge request !808 (merged)
mentioned in merge request !808 (merged)
- Jaime Martinez added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Maintainer
Complete: 95%
Confidence: 100%
Notes: In second round of reviews, should be merged this week too :)
Edited by Jaime Martinez - Maintainer
- Jaime Martinez added workflowverification label and removed workflowin review label
added workflowverification label and removed workflowin review label
- Fiona Neill mentioned in merge request gitlab-com/www-gitlab-com!94878 (merged)
mentioned in merge request gitlab-com/www-gitlab-com!94878 (merged)
- Developer
This was merged and deployed with v3.18.0 (2021-12-09), and it only applies to .com so it is complete and i'm closing it.
- Michelle Torres closed
closed
- Jaime Martinez added workflowproduction label and removed workflowverification label
added workflowproduction label and removed workflowverification label