Backport 0.23 | Fix monitoring resources create / delete loop
What does this MR do?
This is a backport of !681 (merged) to 0.23.x.
Fix monitoring resources create / delete loop
Metric related objects had no type information set, causing them
to be deleted at the end of the reconciliation loop.
Changelog: fixed
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes (!681 (merged)) -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -
Validate potential values for new configuration settings. Formats such as integer10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Related issues
Closes #1392 (closed)
Merge request reports
Activity
added bugfunctional groupdistribution group::distributiondeploy typebug labels
assigned to @clemensbeck
added devopssystems sectioncore platform labels
1 Message Please add the workflowready for review label once you think the MR is ready to for an initial review. Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO.
If you don't receive a response, please mention
@gitlab-org/distribution
, or one of our Project MaintainersIf needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #1392 (closed)
added workflowready for review label
changed milestone to %16.3
requested review from @pursultani
removed workflowready for review label
added workflowin review label
Approved
@mnielsen could you please take another look at it?requested review from @mnielsen
mentioned in commit 819e7364