Fix monitoring resources create / delete loop
What does this MR do?
Fix monitoring resources create / delete loop
Metric related objects had no type information set, causing them
to be deleted at the end of the reconciliation loop.
Changelog: fixed
The objects were not created with explicit type information. As a result, they do not match with the K8s live objects GVR, and are marked for deletion.
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Test Plan
- install the Operator from master
- install prometheus CRDs (https://prometheus-operator.dev/docs/user-guides/getting-started/#installing-the-operator)
- deploy a GitLab CRD
- observe ServiceMonitors are continously created and deleted
- upgrade to this branch's image
- observe ServiceMonitors are created but not deleted
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -
Validate potential values for new configuration settings. Formats such as integer10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Related issues
Relates #621 (closed)
Relates #1392 (closed)
Relates #889 (closed)
Merge request reports
Activity
changed milestone to %16.4
added bugfunctional groupdistribution group::distributiondeploy typebug labels
assigned to @clemensbeck
added devopssystems sectioncore platform labels
1 Message Please add the workflowready for review label once you think the MR is ready to for an initial review. Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO.
If you don't receive a response, please mention
@gitlab-org/distribution
, or one of our Project MaintainersIf needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in merge request !661 (merged)
added 1 commit
- 53f73f98 - Fix monitoring resources create / delete loop
added workflowready for review label
requested review from @pursultani
added workflowin review label and removed workflowready for review label
requested review from @mnielsen
mentioned in commit 83271427
mentioned in merge request !684 (merged)
mentioned in issue #1392 (closed)
mentioned in issue #1407 (closed)