Skip to content

[CI] Fix rules for jobs in tag pipelines

Mitchell Nielsen requested to merge ci-job-rules-fixes into master

What does this MR do?

Configures rules for the template that all QA full suite manual trigger jobs inherit to ensure that the jobs only included in the expected conditions.

This fixes a problem where these jobs would appear in release tag pipelines where they were not needed.

Ensures that the 'build_{tag,bundle}_image' jobs use the same rule as the 'create_followup_issue' job since these should only be included in tag pipelines on canonical.

Testing

I left some comments on how to manually validate the changes.

It's still difficult to fully test/validate CI changes - see further discussions in:

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Related issues

Closes #1271 (closed)

Closes #1326 (closed)

Edited by Mitchell Nielsen

Merge request reports