Skip to content

Revert: Set global.hosts.externalIP on NGINX Service

Mitchell Nielsen requested to merge 513-remove-nginx-workaround into master

What does this MR do?

Revert Set global.hosts.externalIP on NGINX Service

Reverts !328 (a576cf27)

Context from commit message:

This restores original functionality that was mistakenly removed in gitlab-org/charts/gitlab!2267 (merged).

It's been fixed in the Chart itself in gitlab-org/charts/gitlab!2317 (merged), but is not part of Chart version 5.6.0.

This can be removed when Chart version 5.6.1 is added.

Now that all versions in ./CHART_VERSIONS are above the 5.6.1, this workaround can be removed.

Changelog: other

Test plan

  • Confirm that NGINX Service external IP equals global.hosts.externalIP without the workaround in place
apiVersion: apps.gitlab.com/v1beta1
kind: GitLab
metadata:
  name: gitlab
  namespace: gitlab-system
spec:
  chart:
    version: "7.1.2"
    values:
      global:
        appConfig:
          initialDefaults:
            signupEnabled: false
        hosts:
          domain: <my test domain>
          externalIP: <my static IP>
      certmanager-issuer:
        email: mnielsen@gitlab.com

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Related issues

Closes #513 (closed)

Edited by Mitchell Nielsen

Merge request reports