Skip to content

Restore `loadBalancerIP=global.hosts.externalIP` on NGINX Controller Service

Mitchell Nielsen requested to merge set-externalip-for-nginx into master

What does this MR do?

Restores the implementation of global.hosts.externalIP setting on the NGINX Controller Service.

This was one of the modifications we originally made in our fork (documentation link), and was unintentionally overridden in !2267 (merged).

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Jason Plum

Merge request reports