Make Workhorse gracefulShutdownDelay default to shutdown.blackoutSeconds
What does this MR do?
With !4586 (merged),
we are disabling the preStop
hook for Workhorse when the health
check listener is enabled so that Workhorse can signal immediately
that the pod is no longer ready.
However, we still need to observe the blackout time to ensure ongoing
requests complete. Previously this would require the admin to set the
gracefulShutdownDelay
properly, but we should just observe the
blackout time if it's available.
Related issues
Author checklist
For general guidance, please follow our Contributing guide.
Required
For anything in this list which will not be completed, please provide a reason in the MR discussion.
-
Merge Request Title and Description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
MR has a green pipeline. -
Documentation created/updated. -
Tests added/updated, and test plan for scenarios not covered by automated tests. -
Equivalent MR/issue for omnibus-gitlab opened.
Reviewers checklist
-
MR has a green pipeline on https://gitlab.com/gitlab-org/charts/gitlab. -
Consider downstream impact to the Operator, as per evaluating impact from changes to GitLab chart.
Edited by Jason Plum