Skip to content

Disable Workhorse preStop hook if health checker listener is enabled

What does this MR do?

We do not want to use a preStop hook with Workhorse when the health check listener is enabled because the health check listener needs to receive the SIGTERM immediately in order to set its readiness probe to "not ready". Workhorse has a gracefulShutdownDelay setting that should be used instead to drain existing connections.

This fixes the issue reported in gitlab-com/gl-infra/production#20745.

Changelog: fixed

Related issues

Author checklist

For general guidance, please follow our Contributing guide.

Required

For anything in this list which will not be completed, please provide a reason in the MR discussion.

  • Merge Request Title and Description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • MR has a green pipeline.
  • Documentation created/updated.
  • Tests added/updated, and test plan for scenarios not covered by automated tests.
  • Equivalent MR/issue for omnibus-gitlab opened.

Reviewers checklist

Edited by Jason Plum

Merge request reports

Loading