Skip to content

Draft: Remove backup and restore tests

Mitchell Nielsen requested to merge ci-remove-backup-restore-tests into master

What does this MR do?

For the moment at least, this is experimental/exploratory. See the notes below for related discussions.

Removes the backup and restore tests.

Related to #5178

Related to &37 (comment 1694708113)

As referenced in the links above, our tests have some overlap with upstream tests, but they are not exactly the same. As a result, our pipelines break if changes to the backup and restore process change upstream. This can block releases.

Additionally, our process restores from a static, hand-generated backup from a previous version of GitLab. This is not officially supported, and therefore does not follow the process that an end user should be following.

To summarize this comment, we did indeed catch some regressions in Charts CI thanks to these tests. However, catching them in the Charts CI is arguably too late in the development chain and these tests should be "shifted left" closer to their source code. This is also related to gitlab-org&11635, where we're looking into consolidating backups into a single source where testing and validation can be concentrated.

Related issues

Author checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, follow the instructions in the "Reviewer Roulette" section of the Danger Bot MR comment, as per the Distribution experimental MR workflow

For merge requests from forks, consider the following options for Danger to work properly:

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added/updated
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Equivalent MR/issue for Gitlab Operator project opened (see Operator documentation on impact of Charts changes)
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Mitchell Nielsen

Merge request reports