Shift spec/features/backups_spec.rb left
The GitLab chart has this spec/features/backups_spec.rb
which tests backup and restore. The chart uses the backup-utility script which uses the GitLab rake tasks to trigger some of the backup/restore logic. But the backup-utility itself also has its own logic which is a bit different from the Backup/Restore does for GDK/Omnibus.
So roughly,
- The Chart depends on the
backup-utility
which is built by the CNG images. - The
backup-utility
on CNG depends ongitlab-org/gitlab
which provides the rake tasks. - The rake tasks depend on Gitaly which also has some logic regarding backup/restore.
So whenever engineers develop Backup/Restore features upstream, they need to test that Backup/Restore still work. But since the only integration test we have for the chart is triggered by Chart pipelines, we risk only detecting changes that introduce failures when Gitaly was already merged, or GitLab was already merged.
We should figure out a way to either:
- Make Gitaly and GitLab trigger this chart test on an upstream pipeline.
- Add tests to this project that does a similar test to what the chart currently does.
We should consider that this test currently requires a GitLab instance to be deployed to K8s. So it's an expensive test.
Some ideas that were ventilated:
- Make this a manual job that triggers the test upstream.
- Only run the job when we detect that certain files related to backup/restore got changed.
- Create a new test framework.
See original discussion: &37 (comment 1694708113)