Skip to content

Use tcp prefix for KAS service port names

Clemens Beck requested to merge 4908-fix-istio-kas-port-prefix into master

What does this MR do?

Use tcp prefix for KAS service port names

Use tcp instead of grpc as the prefix for KAS service
ports. The prefix is used for istio protocol selection.

Use tcp instead of grpc as the prefix for KAS service
ports. The prefix is used for istio protocol selection.

Closes https://gitlab.com/gitlab-org/charts/gitlab/-/issues/4908
Relates https://gitlab.com/gitlab-org/charts/gitlab/-/issues/3822
Relates https://gitlab.com/gitlab-org/charts/gitlab/-/issues/4028

Changelog: fixed

See: https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/

Related issues

Closes #4908 (closed)

Relates #3822 (closed)

Relates #4028 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Jason Plum

Merge request reports