Gitaly Service Name Missing Istio Required Protocol Previx
Summary
The Gitaly service name when not utilizing TLS does not have a prefix in the name containing protocol-
which is required by Istio for the traffic to be proxied efficiently and coexist happily in the mesh.
Follow on from #3822 (closed)
Steps to reproduce
Install Gitlab 6.5.2+ with Gitaly enabled and using an istio mesh within the cluster.
Configuration used
(Please provide a sanitized version of the configuration used wrapped in a code block (```yaml))
global:
# added to help with Gitlab sub-chart configuration
image:
pullPolicy: IfNotPresent
hosts:
domain: example.com
gitlab:
name: gitlab.example.com
registry:
name: registry.example.com
rails:
bootstrap:
enabled: false
gitlab-runner:
resources:
requests:
cpu: 10m
limits: {}
gitlab:
webservice:
minReplicas: 1
maxReplicas: 1
helmTests:
enabled: false
sidekiq:
minReplicas: 1
maxReplicas: 1
gitlab-shell:
minReplicas: 1
maxReplicas: 1
gitaly:
persistence:
size: 256Mi
resources:
## values raised to help pass CI after default values for gitaly are fixed then can revert to original request.
#requests:
# cpu: 50m
#limits: {}
requests:
cpu: 400m
memory: 600Mi
limits:
cpu: 400m
memory: 600Mi
shared-secrets:
resources:
requests:
cpu: 10m
limits: {}
migrations:
resources:
requests:
cpu: 10m
limits: {}
toolbox:
persistence:
size: 256Mi
resources:
requests:
cpu: 10m
limits: {}
registry:
hpa:
minReplicas: 1
maxReplicas: 1
postgresql:
persistence:
size: 256Mi
metrics:
resources:
requests:
cpu: 10m
limits: {}
minio:
persistence:
size: 256Mi
resources:
requests:
cpu: 50m
limits: {}
redis:
master:
persistence:
size: 256Mi
slave:
persistence:
size: 256Mi
#limits: {}
requests:
cpu: 400m
memory: 600Mi
limits:
cpu: 400m
memory: 600Mi
shared-secrets:
resources:
requests:
cpu: 10m
limits: {}
migrations:
resources:
requests:
cpu: 10m
limits: {}
toolbox:
persistence:
size: 256Mi
resources:
requests:
cpu: 10m
limits: {}
registry:
hpa:
minReplicas: 1
maxReplicas: 1
postgresql:
persistence:
size: 256Mi
metrics:
resources:
requests:
cpu: 10m
limits: {}
minio:
persistence:
size: 256Mi
resources:
requests:
cpu: 50m
limits: {}
redis:
master:
persistence:
size: 256Mi
slave:
persistence:
size: 256Mi
Current behavior
Gitaly service is created without a protocol-
prefix.
Expected behavior
All Gitlab services to be created with protocol-
prefix.
Versions
- Chart: 6.5.2
- Platform:
- Cloud: RKE2 & EKS
- Kubernetes: (
kubectl version
)- Client: 1.23.4
- Server: 1.24.4
- Helm: (
helm version
)- Client: 3.8.0
- Server: Fluxv2 0.36.0
Relevant logs
(Please provide any relevate log snippets you have collected, using code blocks (```) to format)