Skip to content

Retrieve GH access token from QA_GITHUB_ACCESS_TOKEN

Rémy Coutable requested to merge retrieve-github-token-from-qa-variable into master

What does this MR do?

Now that the GH access token is populated from a GCS secret (thanks to https://gitlab.com/gitlab-org/quality/engineering-productivity-infrastructure), we need to actually use the variable set by the automated process: QA_GITHUB_ACCESS_TOKEN.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

After merge

  • Backport to 15-11-stable
  • Backport to 15-10-stable
  • Backport to 15-9-stable
  • Remove the GITHUB_ACCESS_TOKEN variable
Edited by Rémy Coutable

Merge request reports