Global-ize registry services details
What does this MR do?
Added ability to define integration settings for registry
to be defined under global
, allowing to have SSOT for webservice
and sidekiq
configuration and to synchronize those settings with registry
itself.
As a result localized settings (gitlab.{webservice,sidekiq}.registry
) override global.registry
if and when needed.
Harmonized tokenIssuer
setting across all charts under global.registry.tokenIssuer
IMPACTED
Helm minimum version bumped to 3.5.x
+
In the end, this in "perfectly fine", because of Helm's supported version skew has 3.3.x
capped kubernetes 1.18
, which we don't officially support anymore.
"screaming to the future", aka, last known minimal of 1.19.x
+ would be helm 3.7.x
+, and really, 3.8.x
+ makes sense too.
Helm 3.5.4 was April 2021, which is "old" according to K8s release cycles / end of life.
Related issues
Closes #823 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
Merge Request Title and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for omnibus-gitlab opened -
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.