Global-ize registry services details
Summary
!535 (merged) addressed #785 (closed) by adding .Values.registry.*
to the values.yaml
of the Sidekiq chart. At this point, these settings are now present in both charts, some of which are templated only from the local value.
For simplicity of use, and future maintenance, I suggest we move these settings to global.registry.*
, as this key is already present.
Current behavior
global:
registry:
bucket:
certificate: {}
httpSecret: {}
gitlab:
webservice: # updated from `unicorn` to reflect current name
registry:
enabled: # (controls integration)
host:
port:
api:
protocol: http
serviceName: registry
port: 5000
tokenIssuer: gitlab-issuer
sidekiq:
registry:
enabled: # (controls integration)
host:
port:
api:
protocol: http
serviceName: registry
port: 5000
tokenIssuer: gitlab-issuer
Proposed behavior
global:
registry:
bucket:
certificate: {}
httpSecret: {}
# newly global-ized
enabled: # (controls integration)
host:
port:
api:
protocol: http
serviceName: registry
port: 5000
tokenIssuer: gitlab-issuer
Edited by Jason Plum