Skip to content

Ensure Danger doesn't fail when token is rotated

Rémy Coutable requested to merge dont-fail-danger-when-token-is-rotated into master

What does this MR do?

Now, each Danger comment will include an ID, which is based on the Danger token being used.

That way, when the token is rotated, a subsequent run of Danger would create a new comment, instead of trying (and failing) to edit a previous comment.

Related issues

This replaces the leaner solution at !2750 (closed) which we cannot merge until we use rules.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Mitchell Nielsen

Merge request reports