Skip to content

Use application protocol name to set Service port name and appProtocol

Hossein Pursultani requested to merge 3410-port-names into master

What does this MR do?

This MR uses the application protocol name (http, https, grpc, and tls) as the prefix for the Service port name. It also sets appProtocol for Kubernetes 1.20+. This is in line with Istio's explicit port selection. It does not change the container port names.

Related issues

Closes #3410 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Hossein Pursultani

Merge request reports