Ensure Service / Container port name properties align to protocol in use, Istio
Summary
To maintain compatibility with Istio, we need to revisit all Service and container ports[].name
definitions to ensure they accurately reflect the protocol in use.
If an Istio user were to enable TLS on a service, and not have this changed, there would be unexpected results. This is a manual configuration change (and not a small one), so I do not immediately expect users to "bump into" this.
Details
The following discussion from !2673 (merged) should be addressed:
-
@WarheadsSE started a discussion: (+1 comment) In reviewing another MR, I notice that the
service.yaml
template was not updated to reflect thename
&targetPort
, as we have done when we added TLS for Puma.I want to call this out as a minor difference.
There are no changes to the
name
name on thecontainer[].ports[]
entry, so the service is accurately statinghttp
on Service =>http
on Pod. As we have consumers that are using Istio with our chart, we try to consider that use case, and align with Istio protocol selection, which is why we havehttp-XYZ
. We should also change this value tohttps-XYZ
when using TLS.NOTE: Port
name
properties have a maximum length of 15 characters.
Acceptance
-
Find all instances of ports that support http
orhttps
-
Ensure that when TLS is enabled on that port, the port name is changed to reflect that protocol expected.