Skip to content

Support setting Ingress API version via Helm values

Mitchell Nielsen requested to merge 2935-specify-api-versions into master

What does this MR do?

Supports setting the apiVersion field for Ingress objects. Priority is as follows:

  1. Local configuration if set
  2. Global configuration if set
  3. Helm's .Capabilities.APIVersions.Has (when template is run while connected to a live cluster)
  4. extensions/v1beta1 (this is the current default on master - we could update this to networking.k8s.io/v1beta1, but I'm aiming to keep this MR focused on exposing the ability to specify the version - we can consider updating the default version in a separate MR)

Related issues

Closes #2974 (closed) by updating the gitlab.ingress.apiVersion template to consider local values, global values, and Helm's Capabilities.

Closes #2970 (closed) by ensuring that networking.k8s.io/v1 can be configured, assuming the connected Kubernetes cluster has support for that API version. If the template is rendered when not connected to an active cluster, then the API version can be specified via Helm values.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Mitchell Nielsen

Merge request reports