Skip to content

Skip the webservice loadBalancer check if the service is disabled

John Jarvis requested to merge jarv/skip-lb-check-disabled into master

What does this MR do?

This fixes a bug that was introduced in !1726 (merged) for the configuration where webservice is disabled*, but deployments are defined. This is possible because of how values are inherited between the regional cluster (where webservice is disabled) and our zonal clusters (where it is enabled).

In this case for checkconfig, we expect other attributes to be present like type: but they are not so we see the following checkconfig error:

Error: template: gitlab/templates/NOTES.txt:69:3: executing "gitlab/templates/NOTES.txt" at <include "gitlab.checkConfig" .>: error calling include: template: gitlab/templates/_checkConfig.tpl:50:34: executing "gitlab.checkConfig" at <include "gitlab.checkConfig.webservice.loadBalancer" .>: error calling include: template: gitlab/templates/_checkConfig.tpl:463:33: executing "gitlab.checkConfig.webservice.loadBalancer" at <$deployment.service.type>: nil pointer evaluating interface {}.type

Note I am omitting the changelog because !1726 (merged) has not yet been released.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by John Skarbek

Merge request reports