Skip to content

Allow configurable service type and LoadBalancer for Webservice

John Jarvis requested to merge jarv/webservice-loadbalancer into master

What does this MR do?

For #2480 (closed)

This allows us to set a service type of LoadBalancer for a webservice deployment, this gives us the option of bypassing the NGINX ingress which we are exploring for websockets in gitlab-com/gl-infra/delivery#1408 (closed)

The configuration for this looks like:

  gitlab:
    webservice:
+       websockets:
+         service:
+           type: LoadBalancer
+           annotations:
+             cloud.google.com/load-balancer-type: Internal
+         ingress:
+           path:

Marking as draft until we decide whether this is something we want to explore further.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
Edited by Mitchell Nielsen

Merge request reports