Make Ezekiel Kigbo a Frontend Maintainer
Summary
I've been at gitlab for over a year and a trainee maintainer for ~6months and feel ready to take on maintainership. I have had the opportunity to review code across a wide range of teams and community contributions, authored many merge requests and made contributions to our docs and guides.
Closes #5667 (closed)
Links to Non-Trival MRs I've Reviewed
- Add most affected to group security dashboard 1135 -5
- Add hierarchy depth to roadmaps 1145 262
- Update Geo replicable filter nav 111 84
- Design Repo Sync Status - Basic View 1258 1` - Reviewed and suggested this be broken into 2 smaller MR
- Design repository view (geo) 866 2` - Reviewed and suggested breaking down into 3 smaller MR
- Add ability to edit health status in Issue sidebar 359 26
- Design repo sync status: Filtering/search 375 26
- FE for group level Cycle Analytics - refactor old project level feature into Vue 2638 18` - conducted first few rounds of review, then took on the rest of the implementation to see it through
Links to Non-Trivial MRs I've Written
Vue i18n linter
- Added a i18n linter for our
.vue
filters - Authored MRs to fixing detected linting issues across the code base
- Remove pluralize in favour of n__
- i18n - Update documentation examples of string splitting
Implementing customizable value stream analytics
- Broke down the FE related discussions from gitlab-org/gitlab#12196 (closed) into an issue with the FE requirements
- Worked consistently and collaboratively to deliver this over ~12 MRs
Epic - Architecture improvements for value stream analytics (ongoing)
- Proposed changes to the architecture to reduce complexity and improve the level of testing
- Simplifying jest specs and adding additional tests to cover areas that were missed
- Iteratively broken down into multiple issues, each with multiple MRs
- In progress - Move custom stages form to separate module (3 MRs)
- Move type of work charts to separate module (3 MRs)
- Move duration chart to separate module (2 MRs)
- Move recent activity to separate module
Minimal maintainer feedback
- Preserve date filters in analytics
- Remove type of work vuex code from base vue
- Move duration chart to separate component
- Fetch ca summary data from analytics endpoint
- Check for 422 error when editing stage
- Hide default stages and remove custom stages in cycle analytics
Code quality improvements
- Simplify sort order logic
- Follow up - Migrate mock data to fixture spec
- Follow up - consolidate cycle analytics urls
Additional MRs and docs contributions
- Jest - Data driven test examples
- Hide default stages and remove custom stages in cycle analytics
- Information on triggering events in vue tests
- General availablity of customizable value stream analytics
@gitlab-org/maintainers/frontend please chime in below with your thoughts, and approve this MR if you agree.
Once This MR is Merged
-
Create an access request for maintainer access to gitlab-org
. -
Let a maintainer add you to gitlab-org/maintainers/frontend
-
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘
Edited by Ezekiel Kigbo