Trainee FE maintainer (GitLab) - Ezekiel Kigbo
Basic setup
-
Read the code review page in the handbook and the code review guidelines. -
Understand how to become a maintainer and add yourself as a trainee maintainer on the team page.
Large / complex MRs
Authored
- Vue i18n linter
- FE for group level Cycle Analytics - refactor old project level feature into Vue - conducted first few rounds of review, then took on the rest of the implementation to see it through
- Implementing customizable value stream analytics
- Architecture improvements for value stream analytics
- General availablity of customizable value stream analytics
Reviewed
- Design Repo Sync Status - Basic View
- Add most affected to group security dashboard
- Add hierarchy depth to roadmaps
- Design repository view (geo)
- Add ability to edit health status in Issue sidebar
- Design repo sync status: Filtering/search
- Update Geo replicable filter nav
Example Authored MRs
Minimal maintainer feedback
- Preserve date filters in analytics
- Hide default stages and remove custom stages in cycle analytics
- Customizable cycle analytics - Persist custom stages
- API integration - CA tasks by type
Code quality improvements
- Move type of work charts to a separate vuex module
- Follow up - Migrate mock data to fixture spec
- Follow up - consolidate cycle analytics urls
- Remove pluralize in favour of n__
- Simplify sort order logic
Docs contributions
- Jest - Data driven test examples
- i18n - Update documentation examples of string splitting
- Searching rake routes with grep
- Creating feature flags
Working towards becoming a maintainer
There is no checklist here, only guidelines. Remember that there is no specific timeline on this.
It is up to you to ensure that you are getting enough MRs to review, and of varied types. All engineers are reviewers, so you should already be receiving regular reviews from Reviewer Roulette. You could also seek out more reviews from your team, or #frontend Slack channels.
Your reviews should aim to cover maintainer responsibilities as well as reviewer responsibilities. Your approval means you think it is ready to merge.
We recommend to act as a coach in a big deliverable that requires following the planning step as part of the trainee program.
After each MR is merged or closed, add a discussion to this issue using this template:
### (Merge request title): (Merge request URL)
During review:
- (List anything of note, or a quick summary. "I suggested/identified/noted...")
Post-review:
- (List anything of note, or a quick summary. "I missed..." or "Merged as-is")
(Maintainer who reviewed this merge request) Please add feedback, and compare
this review to the average maintainer review.
Note: Do not include reviews of security MRs because review feedback might reveal security issue details.
When you're ready to make it official
When reviews have accumulated, and recent reviews consistently fulfill maintainer responsibilities, any maintainer can take the next step. The trainee should also feel free to discuss their progress with their manager or any maintainer at any time.
-
Create a merge request for team page proposing yourself as a maintainer. -
Create a merge request for CODEOWNERS, adding yourself accordingly, and ask a maintainer to review it. -
Keep reviewing, start merging 🤘