Skip to content

Preserve date filters in analytics

What does this MR do?

  • Fixes the issue with date filters not being preserved when changing filters for both productivity analytics and value stream analytics
  • Moves url parameter updating to a shared mixin
  • Updates tests to reflect use of the shared mixin

Screenshots

No visual changes

Testing

Productivity analytics

  1. Navigate to /-/groups/gitlab-org/-/analytics/productivity_analytics
  2. Select a group
  3. Select project / update date ranges
  4. The query parameters should change
  5. Change the group, date ranges should still be in the query parameters

Value stream analytics

  1. Navigate to /-/analytics/value_stream_analytics
  2. Select a group
  3. Select project / update date ranges
  4. The query parameters should change
  5. Change the group, date ranges should still be in the query parameters

Comparison

  • Switch to your master branch
  • Repeat the above processes
  • The date filters will disappear when you change filters

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #207045 (closed)

Edited by Ezekiel Kigbo

Merge request reports