Skip to content

Add Jacques Erasmus as a maintainer

Jacques Erasmus requested to merge jerasmus-master-patch-87773 into master

This is my proposal to become a frontend maintainer for gitlab-org/gitlab.

I believe I meet the requirements to become a frontend maintainer.

Closes: #5406 (closed)

Links to Non-Trival MRs I've Reviewed

Support for crossplane as a managed app

During review:

Round 1

  • Suggested that we remove some commented code.
  • Suggested that we extract the stack selector into a separate component for the sake of maintainability.
  • Suggested that we add some tests for the stack selector and provided some resources with similar implementation as reference.
  • Noticed that the contributor wasn't using our standard color pallet, I pointed this out and pointed him to our design system.
  • Suggested that we extract some duplicate values into constants for the sake of maintainability.
  • Pointed out an error I came across while testing locally.
  • Suggested that we re-visit the UX of the new feature and assigned to a UX reviewer accordingly.

Round 2

  • I noticed that we're not using our GlDropdown component and prompted the contributor to rather make use of the component.
  • Also mentioned that we can use the GlDropdownItem component instead of <option>...
  • Mentioned that we could clean up/get rid of the CSS that was added.
  • Pointed the contributor to the JS Styleguide to fix the ordering within a Vue file that was added.
  • I suggested a way that we can clean of some of the data flow and make it a bit more maintainable.
  • Mentioned that we can get rid of a redundant scss file.
  • Suggested better property naming.

Round 3

At this point I thought it would be a good idea to start adding patches containing possible fixes for my comments. This was done with the intention of decreasing unnecessary back & forth and potentially missing the upcoming release cut-off.

  • I mentioned that we can improve some of the new specs that was added, I added a patch which the contributor applied.
  • I added a suggestion to destructure a property instead of using JSON.parse(....
  • Fixed a grammar mistake.
  • Removed a redundant label reference.
  • I pointed out a UX issue and suggested a fix after we got UX input.
  • The UX reviewer pointed out that an icon was missing. This wasn't a blocking issue so I opened a separate issue and picked it up myself in the next milestone.

Complete create EKS cluster workflow

During review:

Round 1

  • I suggested better naming of the updateSelectedItems method.
  • I suggested better naming of the select method.
  • I suggested we externalize strings in a few places. The contributor mentioned that he will externalize the strings in a separate MR.
  • I suggested better naming of a ruby property that was defined in a haml template.

Round 2

  • I suggested that we add a spec to assert that the correct icon is displayed.
  • I suggested that we re-use a variable that was already defined, instead of repeating a value.

Specify failing dependencies in the callout message

During review:

  • I noticed that the contributor did not make use of the <callout>... component. I suggested that we use the <callout>... component for the sake of maintainability. I also added possible solutions to get the component to work.

Promote issue to epic "may expose confidential information" ...

During review:

  • I mentioned that it shouldn't be necessary to externalize strings that reference fontawesome icons.
  • I suggested the best way to include the icon with externalizing it.
  • I suggested a way to clean up some unnecessary code.

Add compliance framework label to projects page and listings

During review:

  • I noticed some colors that aren't defined in our design system.
  • I suggested that we rather hardcore class names in our ruby helper instead of color values.
  • I noticed some unnecessary styling that could've been replaced by bootstrap classes.
  • I noticed some unnecessary string translations.

Save changes in Static Site Editor using REST GitLab API

During review:

  • I suggested that we wrap some code in a function for better readability.
  • I noticed an invalid translation.
  • I suggested that we wrap some code in the unit testing for better readability.
  • I noticed a spelling mistake.
  • I suggested better descriptions for some of the unit tests.
  • I noticed a bug and mentioned it together with a gif.

Links to Non-Trivial MRs I've Written

Once This MR is Merged

  1. Create an access request for maintainer access to gitlab-org.
  2. Let a maintainer add you to gitlab-org/maintainers/frontend
  3. Announce it everywhere
  4. Keep reviewing, start merging 🤘 😎 🤘
Edited by Jacques Erasmus

Merge request reports