Skip to content
Snippets Groups Projects

Style ToastUI editor to match design mockups

Merged Jacques Erasmus requested to merge 215121-style-toast-ui-editor into master

This MR ensures that the ToastUI editor is styled to match the design mockups

Note: Changes in this MR are behind the richContentEditor feature flag.

To enable the feature flag:

  1. Run rails c in the project
  2. Run Feature.enable(:rich_content_editor) in the rails console

Test URL: http://localhost:3000/gitlab-org/gitlab-shell/-/sse/master%2FREADME.md

TODO

  • Ensure the editor matches the Mockups
  • Add the necesarry test coverage
  • UX review
  • frontend review

Screenshots

WYSIWYG mode

Screenshot_2020-05-11_at_18.20.51

Markdown mode

Screenshot_2020-05-11_at_18.21.05

Does this MR meet the acceptance criteria?

Conformity

Epic & Design mockups

This issue is part of delivering the feature described in #214559 (closed).

Mockups: #214559 (designs)

Issue: #215121 (closed)

Edited by Jacques Erasmus

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 5af0b79a - Style ToastUI editor to match mockups

    Compare with previous version

  • added 1 commit

    • 88e3f63e - Style ToastUI editor to match mockups

    Compare with previous version

  • Jacques Erasmus changed the description

    changed the description

  • Jacques Erasmus unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Jacques Erasmus marked the checklist item Ensure the editor matches the Mockups as completed

    marked the checklist item Ensure the editor matches the Mockups as completed

  • Jacques Erasmus marked the checklist item Add the necesarry test coverage as completed

    marked the checklist item Add the necesarry test coverage as completed

  • Jacques Erasmus changed the description

    changed the description

  • added 1 commit

    • 26ef9a66 - Style ToastUI editor to match mockups

    Compare with previous version

  • Jacques Erasmus added 267 commits

    added 267 commits

    Compare with previous version

  • added 1 commit

    • eabfe283 - Style ToastUI editor to match mockups

    Compare with previous version

    • Author Maintainer
      Resolved by Jacques Erasmus

      @mle could you please give this a UX review?

      note: This does not include underline as underline is not supported by ToastUI and there is no markdown syntax defined for underlining text. I've raised this in the mockups so we can discuss it further there.

      This also includes the default (side by side) mode for markdown.

      Edited by Jacques Erasmus
  • assigned to @mle

  • Author Maintainer

    @derek-knox could you please give this an initial code review?

  • Please register or sign in to reply
    Loading