Style ToastUI editor to match design mockups
This MR ensures that the ToastUI editor is styled to match the design mockups
Note: Changes in this MR are behind the richContentEditor
feature flag.
To enable the feature flag:
- Run
rails c
in the project - Run
Feature.enable(:rich_content_editor)
in the rails console
Test URL: http://localhost:3000/gitlab-org/gitlab-shell/-/sse/master%2FREADME.md
TODO
Screenshots
WYSIWYG mode
Markdown mode
Does this MR meet the acceptance criteria?
Conformity
Epic & Design mockups
This issue is part of delivering the feature described in #214559 (closed).
Mockups: #214559 (designs)
Issue: #215121 (closed)
Merge request reports
Activity
changed milestone to %13.0
mentioned in issue #215121 (closed)
1 Warning ⚠ This merge request changed files with disabled eslint rules. Please consider fixing them. Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/vue_shared/components/rich_content_editor/constants.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/vue_shared/components/rich_content_editor/constants.js'
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Justin Ho ( @justin_ho
)Tim Zallmann ( @timzallmann
)Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Jacques Erasmus
marked the checklist item Ensure the editor matches the Mockups as completed
added 267 commits
-
26ef9a66...f2a60225 - 266 commits from branch
master
- ffb3c975 - Style ToastUI editor to match mockups
-
26ef9a66...f2a60225 - 266 commits from branch
- Resolved by Jacques Erasmus
@mle could you please give this a UX review?
note: This does not include underline as underline is not supported by ToastUI and there is no markdown syntax defined for underlining text. I've raised this in the mockups so we can discuss it further there.
This also includes the default (side by side) mode for markdown.
Edited by Jacques Erasmus
assigned to @mle
@derek-knox could you please give this an initial code review?
assigned to @derek-knox