Make Denys Mishunov a Frontend Maintainer
Closes #5966 (closed)
After 3+ months of being a trainee maintainer, I finally would like to propose myself as a candidate for becoming a Frontend Maintainer for gitlab-org/gitlab-ui and gitlab-org/gitlab-com. I feel that the quality of my reviews and the MRs I've authored has reached the point when I feel comfortable about this move.
Links to Non-Trival MRs I've Reviewed
| Merge Request | Link to a summary in Trainee Maintainer Issue | Notes |
|---|---|---|
| Styling to avoid wrapping and make button look more like a button | #5966 (comment 255058942) | The process of guiding a ~"Community Contribution" |
| WIP: Resolve "Add gl-responsive-table component" | #5966 (comment 309355435) | First attempt of the responsive table implementation. Based on the review, the MR had to be closed and the new improved one had been submitted |
| Stage all changes by default in Web IDE | #5966 (comment 258580661) | |
| Change --no-commit-message to No commit message | #5966 (comment 273243951) | The MR itself was not non-trivial, however, it was submitted by a non-developer author that required some patches and help with fixing the pipelines along the way |
| Highlight line which includes search term in code search results | #5966 (comment 273250467) | The long-lasting process of ~"Community Contribution" that required several rounds of review and guidance |
| Align dropdown component with spec | #5966 (comment 282113238) | Large MR affecting a lot of components |
| WIP: Resolve "Collapsable sidebar in the web IDE" | #5966 (comment 309448180) | The MR really big changing so many different and unrelated things that it was impossible to properly review. yet, I spent a lot of time reviewing as many things as possible to provide proper and grounded feedback to the author. After all, the MR has been closed by the author as not conforming to GitLab's MR style |
| Step 2 - Fix Web IDE on projects without merge requests | #5966 (comment 309459091) |
Links to Non-Trivial MRs I've Written
- ES Admin UI with multiple indices support [FE]
- WebIDE Default Commit options
- Re-name files in Web IDE in a more natural way
These are quite large ones. Especially the first one (really sorry for pushing @ntepluhina into reviewing that one). And I'm not particularly fond of these as they did not follow the company's value of Iteration. After that, I embraced iteration and am enjoying it a lot. So here are some things that might be not as large as the first entries, however, provide much better handling of Issues and MR in my opinion.
-
Added Monaco-based editor lite version. This one is, in particular, happy about as it introduces the Editor Lite (a lite version of Monaco and our Web IDE), suitable for the use in single-file editor scenario. I'm in particular proud of this one because I came up with the idea for the execution, built the proof of concept and presented it to the group all alongside the main Deliverables (none of which has slipped at that milestone). This MR, yet not overly complex, required a deep understanding of Monaco's internals, its public API and opened the gateway for the unified editing experience in the whole product.
-
Splitting the task of replacing ACE with Monaco into a bunch of smaller Issues (9 as of now) and grouping those by the area of application. The main MR of this block of Issues (for now):
-
Refactor snippets view to Vue issue required more granular split into the smaller chunks as well and resulted in 12 MRs. The most interesting ones would be:
- New re-usable component for Blob File Content
- Set up basic Vue app + GraphQL + Apollo
-
Added the basic Snippet Blob View with Blob Embeddable. The MR itself is not overly complex, however, it's because while working on this MR, I contributed a new component into gitlab-ui (
GlFormInputGroup) that allowed to make this MR so small.
-
Refactor Snippets edit to Vue. This one started as a single Issue that I split into 7 different issues (1 per component to refactor + introduction/rolling out of the feature flag and wrapping all components into the GraphQL mutation to connect the things to backend) based on technical discovery. The process has been executed behind the feature flag. This all resulted in 8 MR so far with the most interesting ones being, apparently:
@gitlab-org/maintainers/frontend please chime in below with your thoughts, and approve this MR if you agree.
Once This MR is Merged
-
Create an access request for maintainer access to gitlab-org. -
Let a maintainer add you to gitlab-org/maintainers/frontend -
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘