Skip to content

Refactor Snippet Edit File field to Vue

Denys Mishunov requested to merge 207240-snippet-edit-filed-vue into master

What does this MR do?

The MR refactors the second bit of Edit File field, namely, the blob editor itself to Vue.

NOTE: this is a part of a larger effort of refactoring Snippet edit form to Vue, hence no CHANGELOG entry has been provided just yet

Important notes:

  • The work in this MR is done behind the :snippets_edit_vue feature flag.
  • For this particular MR, another feature flag might get into play (:monaco_snippets) that replaces ACE editor with Monaco's Editor Lite. This replacement is already in master and is not in the scope of this MR. However, this combination of two feature flags on the same field gives four scenarios for testing (see screenshots below) to make sure things do not get broken.
  • Since this is a WIP to some extent (in the context of the larger effort, as mentioned above), this component is not rendered in the form just yet and will be enabled in one of the later MRs. To click test the functionality now, you can download the patch to apply additional changes locally.

Screenshots

Before After
🛑 :monaco_snippets
🛑 :snippets_edit_vue
Screenshot_2020-03-06_at_16.13.32 Screenshot_2020-03-06_at_16.39.02
:monaco_snippets
🛑 :snippets_edit_vue
Screenshot_2020-03-06_at_16.23.26 Screenshot_2020-03-06_at_16.39.46
🛑 :monaco_snippets
:snippets_edit_vue
Screenshot_2020-03-06_at_16.13.32
Note: :snippets_edit_vue didn't exist, hence the rendering is driven only by the state of :monaco_snippets
Screenshot_2020-03-06_at_16.43.13
:monaco_snippets
:snippets_edit_vue
Screenshot_2020-03-06_at_16.23.26
Note: :snippets_edit_vue didn't exist, hence the rendering is driven only by the state of :monaco_snippets
Screenshot_2020-03-06_at_16.43.54

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

References #207240 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports