Replace ACE with Monaco for Snippets editing/creation

changed milestone to %12.9

added Stretch devopscreate frontend groupeditor [DEPRECATED] typefeature workflowscheduling labels

added 1 commit

e31b17f2 - Support Monaco editor in Snippet edit form

	1 Error
	dbe50cdb: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body

Commit message standards

One or more commit messages do not meet our Git commit message standards.

For more information on how to write a good commit message, take a look at How to Write a Git Commit Message.

Here is an example of a good commit message:

Reject ruby interpolation in externalized strings

When using ruby interpolation in externalized strings, they can't be
detected. Which means they will never be presented to be translated.

To mix variables into translations we need to use `sprintf`
instead.

Instead of:

    _("Hello #{subject}")

Use:

    _("Hello %{subject}") % { subject: 'world' }

This is an example of a bad commit message:

updated README.md

This commit message is bad because although it tells us that README.md is updated, it doesn't tell us why or how it was updated.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
frontend	André Luís (`@andr3`)	Kushal Pandya (`@kushalpandya`)
QA	Grant Young (`@grantyoung`)	Sanad Liaquat (`@sliaquat`)
test Quality for `spec/features/*`	Tomislav Nikić (`@tmslvnkc`)	No maintainer available

Generated by Danger

added 365 commits

e31b17f2...2abc63f1 - 364 commits from branch master
ba24af40 - Support Monaco editor in Snippet edit form

Compare with previous version

added 550 commits

ba24af40...dcc1cd1b - 549 commits from branch master
023f2b34 - Support Monaco editor in Snippet edit form

Compare with previous version

added 1 commit

55b13301 - Support Monaco editor in Snippet edit form

Compare with previous version

added 1 commit

9e7bc6e2 - Support Monaco editor in Snippet edit form

Compare with previous version

@andr3 can not argue with Danger here :) Could you please do the first round of FE review here?

@mlapierre could you please review the feature specs in this MR? Thank you :)

assigned to @mlapierre and @andr3

assigned to @jboyson and unassigned @andr3

unmarked as a Work In Progress

changed the description

unassigned @jboyson

approved this merge request

@mishunov Looks good! Just a couple of non-blocking questions. I'll leave you to assign to maintainer after you have decided what to do with them.

added workflowin review label and removed workflowscheduling label

resolved all threads

added 1 commit

a715a521 - Support Monaco editor in Snippet edit form

Compare with previous version

Since I have updated QA Page object, we should involve QA into the process as well. And since ~"group::editor" has a an assigned counterpart in testing, I think it only makes sense to do what I had to do in the first place: involve @a_mcdonald :)

@a_mcdonald could you please review this one from the testing (QA and otherwise) standpoint? @mlapierre has already unofficially approved from ~Quality side, however.

assigned to @a_mcdonald and unassigned @mlapierre

approved this merge request

unassigned @a_mcdonald

resolved all threads

Thank you very much @mlapierre and @a_mcdonald! Then I take it as both test and QA are approved and the MR is in proper shape to be sent to a maintainer.

@kushalpandya could you please take a look at this one and merge if it looks fine? Thank you