Update pslaughter to FE maintainer for CE and EE
Summary
This MR is my proposal to becoming a frontend maintainer for GitLab CE & EE. Since starting at GitLab, reviewing peer and community MR's is something I've sought to specialize in and perfect. In recent months, my manager (@andr3) and others have repeatedly encouraged me to pursue becoming a maintainer, which would better serve our team and product.
To support this proposal, here is a sample of reviewed and authored MR's:
Reviewed MR's
-
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24724 ( +783 -215 )
- One small comment from Phil.
-
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24296 ( +185 -41 )
- No further comments from Phil.
-
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8519 ( +195 -71 )
- Some comments from Fatih, mostly clarifying but only one tiny actual comment.
-
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9656 (FE is about +200 -20 )
- Minor comment from Phil.
-
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24771 ( +219 -88 )
- Minor comments only for clarification from Phil.
-
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23022 ( +82 -24 )
- No further comments from Filipa.
Authored MR's
-
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25700 ( +249 -152 )
- Some comments to discuss, without request for significant changes.
-
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9452 ( +1638 -32 )
- Some minor comments form Phil, without request for significant changes.
- (from @andr3: Impressive organization of work for such a large feature: Main FE MR).
-
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24139 ( +219 -0 )
- No request for changes.
-
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8593 ( +453 -205 )
- The comments left by Winnie and Phil were minor and mostly about improving the preexisting code.
-
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8685 ( +1193 -56 )
- Some minor comments from Phil without request for significant changes.
-
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8732 ( +1614 -61 )
- Some minor comments from Phil without request for significant changes.
Questions
Why not become a trainee maintainer
?
According to the handbook:
It is not necessary to go through the trainee maintainer stage to become a maintainer. Reviewers can make the case for their own maintainership status,
In the opinion of my manager (@andr3) and myself there is already a case for becoming a maintainer, so this extra step would not provide a lot of value.
/cc @andr3 @iamphill @fatihacet @mikegreiling @filipa @ClemMakesApps @kushalpandya @annabeldunstone @timzallmann @DouweM @nick.thomas