Skip to content

Add msaleiko as backend maintainer

Marc Saleiko requested to merge msaleiko-master-patch-f68e into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".

@msaleiko has reviewed over 70 merged MRs and authored over 180 merged MRs. He's been with GitLab for 1.75 years and started reviewing about a year ago (due to being in the Incubation Engineering Department before) and recently joined the devopsplan stage and the groupproject management team.

  • Passes on context when he has further domain knowledge on how to improve the MR or make the code easier 1, 2
  • Cares about potential performance pitfalls 1
  • Focuses on code quality 1, 2
  • Ensure the UI looks good 1
  • Ensures metadata is correct 1, 2, 3, 4, 5, 6
  • Encourages code readability and re-use existing code when possible 1, 2, 3
  • Identifies missing test cases and improves test case quality 1, 2, 3, 3, 4, 5, 6, 7

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty with the template below.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.
Template call to action
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT. 

* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement, and can vouch for this proposal, please approve.

After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.

Once This MR is Merged

  1. Join the #backend_maintainers Slack channel
  2. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  3. Let a maintainer add you to @gitlab-org/maintainers/rails-backend with Owner access level.
  4. Announce it everywhere
  5. Familiarize yourself with documentation for Merging a merge request
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Mario Celi

Merge request reports