Skip to content

Service Desk: sending uploads as email attachments

What does this MR do and why?

This changes allow to send uploads, that were added to note, as email attachments when total size is less than 10mb. New logic will replace all uploads link in text with just names of uploads(bold). And all uploads will be sent as email attachments.

Behaviours and UX considerations

Service desk agents may send files to email participants. Some Service Desk instances have settings that wouldn't allow email participants to view attachments hosted on GitLab. To ensure attachments can be accessed they will be added to emails as attachments (see #11733 (closed) for more context).

Notes are added using Markdown, and allow SD agents to use all of the GFM syntax.

The following solution has been proposed to balance maintain context and maximising readability:

Markdown GitLab display Email display
Please sign and return the [contract](/uploads/8e107c2ea7bc2bd9eec2a7792affc4e8/DMH_Contract_2023.pdf). I've also attached [DMH_ToS_2023.pdf](/uploads/1c60f1794b6df66c8bae5dbe6118a152/DMH_ToS_2023.pdf) as you've requested. Please sign and return the contract. I've also attached DMH_ToS_2023.pdf as you've requested. Please sign and return the contract (DMH_Contract_2023.pdf). I've also attached DMH_ToS_2023.pdf as you've requested.

More discussion in the following thread !107887 (comment 1229926987).

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
before after

How to set up and validate locally

  1. Go to any Service Desk issue.
  2. Left some comment with uploads.
  3. Check you email.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #11733 (closed)

Edited by Dan Mizzi-Harris

Merge request reports