Skip to content

Add Desiree Chevalier as gitlab_quality-test_tooling maintainer

Désirée Chevalier requested to merge add-dchevalier-as-gitlab-quality-test-tooling-maintainer into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as it is justified".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

Based on the guidelines for GitLab Quality Test Tooling mentioned in Project Management - Reviewers and Maintainers, it is recommended to author or review 5 MRs. Below are a few examples of MRs I have authored for GitLab Quality Test Tooling meeting this criteria. Note that the GitLab Quality Test Tooling gem was recently created and contains code that used to reside in gitlab-qa so most of these MRs are from gitlab-qa. I am a trainee maintainer of gitlab-qa as well.

  1. Use hub test cases for test result issues
  2. Update reporting script to update test case and issue titles
  3. Remove link to testcase when test passed
  4. Add screenshots to failure issues
  5. Fixes skip reporting for ignored failures when multiple failures occur

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.

Once This MR is Merged

  1. Create an access request for maintainer access to gitlab-org/ruby/gems/gitlab_quality-test_tooling.
  2. Join the [infrastructure-department](https://gitlab.slack.com/archives/C02GR2DV5QT) (internal) slack group
  3. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  4. Announce it everywhere
  5. Keep reviewing, start merging 🤘 😎 🤘
Edited by Désirée Chevalier

Merge request reports