Skip to content

Speed up review apps

Vladimir Shushlin requested to merge vshushlin/speed-up-review-apps into main

Why is this change being made?

Following up on Make review apps manual (#267 - closed) • Cynthia "Arty" Ng

I'm trying to speed-up the review apps, so maybe we don't need to make them optional.

  • use simpler docker image
  • don't do git checkout
  • only download build artifacts

Results

  • Speed up from 3 min per job to 2 min
  • But actually, I realized that we don't need a separate `review-app`, we just need to refactor the build job a bit. I'll work on it later, but want to merge this.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Division: If the update affects your division, share the MR in your division Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Commits

  • Speed up review apps
Edited by Vladimir Shushlin

Merge request reports