Add ignoreErrors to config
Why is this change being made?
This is a temporary solution for Failing to pull embed breaks pipeline jobs (#178 - closed). A proper solution should be implemented as part of Handle tweet errors properly (#179).
This MR adds the ignoreErrors
section to the Hugo config file.
Pros:
- Build will pass, suppressing/ignoring the error codes added to the list.
- The content is simply ignored on the rendered HTML page. For example, in this commit, the job succeeds and the content of https://gitlab-com.gitlab.io/-/content-sites/handbook/-/jobs/6059094011/artifacts/public/handbook/company/culture/all-remote/informal-communication.html simply skips the errored content.
Cons:
- The
error-remote-getjson
code is too broad, any external request that fails to load content will be ignored as seen in this job. - We may not want to ignore ALL external requests as this may render incomplete content in the handbook.
Author and Reviewer Checklist
Please verify the check list and ensure to tick them off before the MR is merged.
-
Provided a concise title for this Merge Request (MR) -
Added a description to this MR explaining the reasons for the proposed change, per say why, not just what - Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
-
Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI) - If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
Maintained by
section on the page being edited - If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
- The when to get approval handbook section explains the workflow in more detail
- If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
-
For transparency, share this MR with the audience that will be impacted. -
Team: For changes that affect your direct team, share in your group Slack channel -
Department: If the update affects your department, share the MR in your department Slack channel -
Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR - For high-priority company-wide announcements work with the internal communications team to post the update in #company-fyi and align on a plan to circulate in additional channels like the "While You Were Iterating" Newsletter
-
Closes #178 (closed)
Edited by Jaime Martinez