Skip to content

Resolve "Mobile: can't apply to stores, window cut off"

Paul-Gabriel Müller requested to merge 765-store-scrolling2 into master

Closes #765 (closed)

What does this MR do?

(briefly describe what this MR is about) Fix #765 (closed) by refactoring the code to work for "stores" as it does for "basket" in the Map View. Followup of !1357 (closed)

How confident are you it won't break things if deployed?

Quite likely that some edge cases do have bugs, should be tested by different users

Any relevant links (issues, documentation, slack discussions).

!1167 (closed) !1357 (closed) #765 (closed)

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. On the map, click on Stores and try to interact with them (join, cancel request etc)

(Unit tests not possible, as this is mostly a front end change)

Screenshots (if applicable)

See !1357 (closed)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Alex

Merge request reports