Closed: Resolve "Mobile: can't apply to stores, window cut off", Refactoring to use StoreXHR

See follow up: !1378 (merged)

Closes #765 (closed)

What does this MR do?

Fix #765 (closed) by refactoring the code to work for "stores" as it does for "basket" in the Map View

How confident are you it won't break things if deployed?

Quite likely that some edge cases do have bugs, should be tested by different users

Links to related issues

!1167 (closed) #765 (closed)

How to test

1. Checkout branch locally
2. On the map, click on Stores and try to interact with them (join, cancel request etc)

(Unit tests not possible, as this is mostly a front end change)

Screenshots (if applicable)

Before: After:

Checklist

• added a test, or explain why one is not needed/possible...
• no unrelated changes
• asked someone for a code review
• joined #foodsharing-beta channel at https://slackin.yunity.org
• added an entry to CHANGELOG.md (description, merge request link, username(s))
• Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings

added typeBug + 1 deleted label

Ich weiß, dass noch etwas Fleißarbeit aussteht - z.B. changelog und Rebase. Aber vielleicht kann ja trotzdem schon mal jemand schauen, ob ich technisch/inhaltlich gröbere Schnitzer drin habe;)

changed the description

mentioned in commit 2437c9e0

added 1 commit

• 2437c9e0 - !1357 (closed) Make changes based on feedback from @ctwx_ok

Compare with previous version

mentioned in commit 18950680

added 68 commits

• 2437c9e0...6adc2961 - 54 commits from branch master
• 56e4b121 - #765 (closed): Work in progress, smaller fixes
• 2b8fab50 - #765 (closed): Syntax (empty lines whitespace)
• f2915f2e - #765 (closed): Start with moving strings to lang.php file for Stores
• d0919372 - formatting issues
• 0c2315d0 - formatting again
• 4f8b4069 - more formatting issues (whitespace)
• 9fd98bae - more whitespace formatting issues - I really should set up formatting
• 60c2f549 - exernalize strings in bubble method
• 294094ff - formatting, after running ./scripts/fix
• fb309c46 - Remove bBubble Method, call ajreq from store page as well
• c1f4bfbe - formatting
• 18950680 - !1357 (closed) Make changes based on feedback from @ctwx_ok
• 91b1fb20 - Merge branch '765-store-scrolling' of...
• 75a9706e - Changelog.md

Compare with previous version

marked the checklist item no unrelated changes as completed

changed the description

marked the checklist item asked someone for a code review as completed

marked the checklist item joined #foodsharing-beta channel at https://slackin.yunity.org as completed

marked the checklist item added a test, or explain why one is not needed/possible... as completed

marked the checklist item added an entry to CHANGELOG.md (description, merge request link, username(s)) as completed

unmarked as a Work In Progress

resolved all threads

added 1 deleted label

The only concern I have is the one from !1167 (closed): if the content is scrollable but the button stays fixed, then people might read even less what's written there.

But apart from that I really like how you solved this!

approved this merge request

added 1 commit

• 1762d0a1 - Make buildBubbleDialog private

Compare with previous version

resolved all threads

approved this merge request

resolved all threads

@panschk can you try to rebase it locally?

added 27 commits

• 1762d0a1...2b285357 - 23 commits from branch master
• 80918903 - #765 (closed): Work in progress, smaller fixes
• e95b4b02 - #765 (closed): Syntax (empty lines whitespace)
• 24347990 - #765 (closed): Start with moving strings to lang.php file for Stores
• add22fbc - squash more commits

Compare with previous version

added 8 commits

• add22fbc...407fccb2 - 3 commits from branch master
• 5a5e4651 - #765 (closed): Work in progress, smaller fixes
• b3f6e325 - #765 (closed): Syntax (empty lines whitespace)
• 4b6c966e - #765 (closed): Start with moving strings to lang.php file for Stores
• 9cacd95a - squash more commits
• aec2e916 - Merge branch '765-store-scrolling' of...

Compare with previous version

resolved all threads

Oh great, now the pipeline failed.... Git and me will not become best buddies I fear :(

https://gitlab.com/foodsharing-dev/foodsharing/pipelines/123279120

The easiest way is probably to create a new branch on top of current master with only the changes that are in here now. Would you mind doing that?

Excellent idea. I'll do that tomorrow!

See !1378 (merged) - somehow the validation (pipeline) now fails for classes which should be part of the master since a while. I just don't "git" it ;-)

mentioned in merge request !1378 (merged)

closed

changed title from Resolve "Mobile: can't apply to stores, window cut off", Refactoring to use StoreXHR to Closed: Resolve "Mobile: can't apply to stores, window cut off", Refactoring to use StoreXHR

changed the description