Angelos Evripiotis authored Feb 05, 2019 and Angelos Evripiotis committed Feb 15, 2019

Remove the need for the 'really-workspace-close-project-inaccessible'
config option, as well as the option itself.

As agreed on the mailing list [1], all the 'are you sure?' prompts on
workspace reset and close were removed. While that discussion was going
on, this new prompt and option was added. At the 2019 BuildStream
Gathering, it was verbally agreed between myself and Tristan VB that we
would also remove this instance.

It was also agreed that we should have a notice to let the user know
what they'd done, this was already in place if interactive. Moved it to
be unconditional so that there's no difference in non-interactive
behaviour. Made it output to stderr, as it's diagnostic meant for the
user. Made it the last thing echo'd so it's next to the prompt - it's
very relevant to what they type next. Added a test to make sure the text
makes it to stderr in the appropriate case, and not in an inappropriate
one.

This is the last instance of any prompt configuration, so BuildStream
can also forget all of that machinery.

[1] https://mail.gnome.org/archives/buildstream-list/2018-December/msg00111.html

userconfig: rm really-workspace-close-project-inaccessible

Closes #726 and #744

See merge request !1130

See buildstream-docker-images#26
for detailed discussion around this.

`buildstream/buildstream-fedora` is now considered deprecated. Switch to
`buildstream/buildstream` image. This image also offers more tags that
will provide users more flexibility.

Now that the `buildstream/buildstream` image has 9 variants, let's make
it easier to choose the desired tag, using a command-line option.

This is otherwise possible by specifying the full image name `image:tag`
using the `-i` option. But, this will make it easier to specify just the
tag using `-j`.

The following two invocations of `bst-here` are now equivalent:

    bst-here -i buildstream/buildstream:dev
    bst-here -j dev

contrib/bst-here: Allow users to specify image variant

See merge request !1153

[ci skip]

README.rst: Add table with distros with packaged buildstream

See merge request !1143

So that other people can also make releases.

CONTRIBUTING.rst: Documenting the release process

See merge request !1155

The directory needs to be serialized after the Digest for the
subdirectory `caller` has been updated.

ArtifactCache.commit() is no longer the only expensive part and even
more so with the upcoming change to use CASBasedDirectory.

Cache artifacts with virtual directories instead of filesystem.

Closes #787

See merge request !991

Having `pkg-resources` in requirements files is never the right thing as
it is not really a package that one can install. This is basically an
artifact of Debian-based systems providing incorrect metadata to pip.
See [this pip issue](https://github.com/pypa/pip/issues/4022) and
[this Ubuntu issue](https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/1635463)
for more background.

requirements/Makefile: exclude pkg-resources

Closes #918

See merge request !1156

Tristan Van Berkom authored Feb 18, 2019 and Tristan Van Berkom committed Feb 18, 2019

The test jobs which create coverage reports need to be listed
in the dependencies of the coverage job, as highlighted in
issue #356.

.gitlab-ci.yml: Some new test environments were added, but not collecting coverage.

See merge request !1157

Allow WSL tests to run, but they don't block the CI

See merge request !1159

Chandan Singh authored Feb 19, 2019 and Chandan Singh committed Feb 18, 2019

Since `CalledProcessError` is defined by the `subprocess` module, it
must be caught as `subprocess.CalledProcessError`, and not as simply
`CalledProcessError`.

doc/badges.py: Fix catching of CalledProcessError

See merge request !1160

Chandan Singh authored Feb 19, 2019 and Jürg Billeter committed Feb 19, 2019

Instead of importing `Mapping` from `collections`, it must be imported
from `collections.abc`, as the old method will stop working from Python
3.8.

buildstream/_yaml.py: Import Mapping from collections.abc

See merge request !1161

Gökçen Nurlu authored Dec 17, 2018 and Jürg Billeter committed Feb 19, 2019

That step is not actually part of the build phase should not be cached and
causes hard to find bugs.

Fixes #791

Prevent caching when Element.stage() fails

Closes #791

See merge request !1012