Chandan Singh authored Aug 24, 2018 and Tristan Van Berkom committed Aug 29, 2018

- setup.py: List useful links using `project_urls`

- setup.py: Specify minumum python vresion using `python_requires`

  `python_requires` is the new way of specifying requirements for python
  version, as documented @
  https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires.

  This will also make this requirement appear nicely on the PyPI project
  page.

- setup.py: Add project classifiers

  PyPI will use these classifiers to categorize projects while searching
  or browsing. Full list of classifiers can be found at
  https://pypi.org/classifiers.

setup.py: Add more metadata useful for PyPI

See merge request !718

Qinusty authored Aug 29, 2018 and Tristan Van Berkom committed Aug 29, 2018

Fixes #597

Fix ValueError traceback for URL without alias or URI scheme

Closes #597

See merge request !700

Disable round-tripping when element is not modified

See merge request !748

Log not-found objects in the cache as SKIPPED

See merge request !729

Qinusty authored Aug 23, 2018 and Qinusty committed Aug 29, 2018

This aims to address #600, this will raise an exception when a resolved
variable contains a reference to the variable.

Qinusty authored Aug 29, 2018 and Qinusty committed Aug 29, 2018

Note: This modifies the docker containers used for testing to supply the
pytest-timeout package.

Add cyclic check within variable resolution

See merge request !712

There is no reason that the filter element codepaths can behave
differently depending on the Source implementation used in the test,
as the Source implementation does not have any filter specific
virtual methods.

Removing the redundant tests and just performing these tests with the git source.

tests/plugins/filter.py: Don't run redundant tests

See merge request !753

This test was skipped because of issue #538, but #538 was fixed
and the test was still not reenabled.

tests/frontend/mirror.py: Reenable test_mirror_fetch_upstream_absent[ostree]

See merge request !755

Added some comments to make the flow easier to follow, and
removed an annoying 'success' variabled in favor of a for / else
loop statement.

This was sitting in the section for abstract methods, but this
is most definitely not an abstract method to be implemented by
Sources.

This was displaying the aliased URL which is pretty useless,
use the translated URL for the timed activity.

Minor code changes revolving around source mirroring

See merge request !758

Failures to write files when tracking were not reported.

Fixes #533.

Report processing errors from tracking

Closes #533

See merge request !747

This is causing issues while the size file is being read and written
simultaneously.

The proper fix will be to read/add/save the file atomically and that
will require locking, but this fix is a good stop gap to existing crashes.

_artifactcache/artifactcache.py: Write the cache_size file atomically

See merge request !762

Replacing string 'bzr' with value from host tools

See merge request !764

Explicitly check that project.conf contains a name. This resolves
the issue of the provenance check from _yaml.py incorrectly reporting
the offending file as the default_config_node projectconfig.yaml
when no name key exists in the pre_config_node dict.

buildstream/_project.py: Report if project.conf is missing name

See merge request !680

This adjusts the message handler for the child processes to no longer
override the message type.

This also removes the ability for unhandled non BstError exceptions to
retry.

Retries log as failures

See merge request !766

This prevents the cache_size.pid.log files from cluttering the root
log directory.

Move cache_size.pid.log files into a subdirectory of logs

See merge request !769

Also highlight the fact that the plugin can rely on the fetcher's
fetch() method getting called before consuming the next item in the
list, which is the magick behavior that the git plugin relies on.

This is a part of #620

A download URL must be interpreted by the core at `Plugin.configure()`
time, even if only employed later on.

This is a part of #620

Keeps track of whether the plugin is currently being configured.

Adjusted Element and Source classes to call _configure() in place
of calling configure() directly.

This is a part of #620

The Source must now mention whether the marked or translated
URL is "primary" or not. Even when a Source may have multiple
URLs, the auxilliary URLs are derived from the primary one, not
only is this true for git, but it is mandated by our tracking
API which assumes there is a primary URL.

This adjusts the `git` source and the test `fetch_source.py` source
to behave properly and advertize it's primary URL properly.

This is a part of #620

This cannot test for unaliased URLs, as those can be discovered later
on outside of user provided element configuration; at least we
assert that if an alias was used, we have seen it at load time.

This will cause a BUG to occur for a plugin which marks an aliased
URL (or attempts to translate one) outside of `Plugin.configure()`,
if that URL was not previously seen.

This is a part of #620

Source fetcher changes

See merge request !772

Add a helper function assert_ref_in_track to git.py GitMirror()
which is used when staging & initing the source workspace. It
checks the element's ref exists in the track (branch/tag) if it
has been specified, raising a warning if necessary. The warning makes
use of the warning token 'REF_NOT_IN_TRACK' from the configurable
CoreWarnings. If the element has been tracked with bst, it is assumed
that the value of ref exists in the track as it was generated from it
& as such is not asserted.

Add tests that cover assert_ref_in_track & the configurable
CoreWarnings REF_NOT_IN_TRACK warnings token.

plugins/git.py: Warn if ref is not in given track

See merge request !564

Tom Coldrick authored Aug 29, 2018 and Tom Coldrick committed Sep 08, 2018

Adds a modified version of the freedesktop-sdk `strip-binaries` to
buildstream default `project.conf`. We implemented a few changes to
the current default, but the main change is to fix a bug due to
permissions.

The modifications I made to the freedesktop-sdk commands as they are
at present are as follows:
* Remove debugedit rules to include source debugging
* Add a switch to allow failing on error, rather than this being
  the default behaviour.
These changes mean that we should now have a sensible default for
a wide variety of users.